Re: [PATCH] Support % wildcard in extension upgrade filenames
Sandro Santilli <strk@kbt.io>
From: 'Sandro Santilli' <strk@kbt.io>
To: Regina Obe <lr@pcorp.us>
Cc: 'Christoph Berg' <cb@df7cb.de>, pgsql-hackers@lists.postgresql.org, pgsql-hackers@postgresql.org, 'Laurenz Albe' <laurenz.albe@cybertec.at>, 'Tom Lane' <tgl@sss.pgh.pa.us>, 'Paul Ramsey' <pramsey@cleverelephant.ca>
Date: 2022-11-16T23:09:33Z
Lists: pgsql-hackers
Attachments
- 0001-Allow-wildcard-in-extension-upgrade-paths.patch (text/x-diff)
On Sun, Nov 13, 2022 at 11:46:50PM -0500, Regina Obe wrote: > > Re: Sandro Santilli > > > I'm attaching an updated version of the patch. This time the patch is > > > tested. Nothing changes unless the .control file for the subject > > > extension doesn't have a "wildcard_upgrades = true" statement. > > > > > > When wildcard upgrades are enabled, a file with a "%" symbol as the > > > "source" part of the upgrade path will match any version and > > > > Fwiw I believe wildcard_upgrades isn't necessary in the .control file. > > If there are no % files, none would be used anyway, and if there are, it's > clear > > it's meant as wildcard since % won't appear in any remotely sane version > > number. > > I also like the idea of skipping the wildcard_upgrades syntax. > Then there is no need to have a conditional control file for PG 16 vs. older > versions. Here we go. Attached a version of the patch with no "wildcard_upgrades" controlling it. --strk;