Re: allow segment size to be set to < 1GiB

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Peter Geoghegan <pg@bowt.ie>
Date: 2022-11-09T20:25:09Z
Lists: pgsql-hackers

Attachments

Hi,

On 2022-11-09 14:44:42 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > A second question: Both autoconf and meson print the segment size as GB right
> > now. Obviously that'll print out a size of 0 for a segsize < 1GB.
> 
> > The easiest way to would be to just display the number of blocks, but that's
> > not particularly nice.
> 
> Well, it would be fine if you'd written --with-segsize-blocks, wouldn't
> it?  Can we make the printout format depend on which switch was used?

Not sure why I didn't think of that...

Updated patch attached.

I made one autoconf and one meson CI task use a small block size, but just to
ensure it work on both. I'd probably leave it set on one, so we keep the
coverage for cfbot?

Greetings,

Andres Freund

Commits

  1. Add option to specify segment size in blocks