Re: Incorrect include file order in guc-file.l

Julien Rouhaud <rjuju123@gmail.com>

From: Julien Rouhaud <rjuju123@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-02T06:01:05Z
Lists: pgsql-hackers
Hi,

On Wed, Nov 02, 2022 at 02:29:50PM +0900, Michael Paquier wrote:
>
> While reviewing a different patch, I have noticed that guc-file.l
> includes sys/stat.h in the middle of the PG internal headers.  The
> usual practice is to have first postgres[_fe].h, followed by the
> system headers and finally the internal headers.  That's a nit, but
> all the other files do that.
>
> {be,fe}-secure-openssl.c include some exceptions though, as documented
> there.

Agreed, it's apparently an oversight in dac048f71eb.  +1 for the patch.



Commits

  1. Remove unneeded includes of <sys/stat.h>

  2. Remove outdated include

  3. Straighten include order in guc-file.l