Horton

Re: Crash after a call to pg_backup_start()

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, guofenglinux@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2022-10-24T09:39:19Z
Lists: pgsql-hackers 
On 2022-Oct-24, Michael Paquier wrote:

> On the contrary, it seems to me that putting the assertion within the
> if() block makes the assertion weaker, because we would never check
> for an incorrect state after do_pg_abort_backup() is registered (aka
> any pg_backup_start() call) when not entering in this if() block.

Reading it again, I agree with your conclusion, so I'll push as you
proposed with some extra tests, after they complete running.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"La verdad no siempre es bonita, pero el hambre de ella sí"

Commits

  1. Fix recently added incorrect assertion