Horton

Re: hash_xlog_split_allocate_page: failed to acquire cleanup lock

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Mark Dilger <mark.dilger@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Date: 2022-10-17T20:30:02Z
Lists: pgsql-hackers 
On 2022-10-17 13:34:02 -0400, Robert Haas wrote:
> I don't feel quite as confident that not attempting a cleanup lock on
> the new bucket's primary page is OK. I think it should be fine. The
> existing comment even says it should be fine. But, that comment could
> be wrong, and I'm not sure that I have my head around what all of the
> possible interactions around that cleanup lock are. So changing it
> makes me a little nervous.

If it's not OK, then the acquire-cleanuplock-after-reinit would be an
active bug though, right?

Commits

  1. Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.