Re: meson PGXS compatibility

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Nazir Bilal Yavuz <byavuz81@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2022-10-05T21:10:22Z
Lists: pgsql-hackers
Hi,

On 2022-10-05 16:58:46 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > My understanding, from that commit message, was that the issue originates in
> > apple's ranlib setting the timestamp to its components but only queries / sets
> > it using second granularity. I verified that apple's ranlib and ar these days
> > just set the current time, at a high granularity, as the mtime.  Whether or
> > not make then hides the problem seems not that relevant if the source of the
> > problem is gone, no?
> 
> Well, (a) it seemed to happen in only some circumstances even back then,
> so maybe your testing didn't catch it; and (b) even assuming that Apple
> has fixed it in recent releases, there may still be people using older,
> un-fixed versions.  Why's it such a problem to keep the "touch" step?

It isn't! That's why I said that I was on the fence about removing the touch
in my first email and then that I'd leave the touch there and just
s/ranlib/ar/ in my reply to you.

Greetings,

Andres Freund



Commits

  1. meson: Add basic PGXS compatibility

  2. autoconf: Move export_dynamic determination to configure

  3. autoconf: Don't AC_SUBST() LD in configure

  4. autoconf: Unify CFLAGS_SSE42 and CFLAGS_ARMV8_CRC32C

  5. autoconf: Rely on ar supporting index creation