Re: archive modules

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Benoit Lobréau <benoit.lobreau@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Robert Haas <robertmhaas@gmail.com>, "Bossart, Nathan" <bossartn@amazon.com>, David Steele <david@pgmasters.net>, Fujii Masao <masao.fujii@oss.nttdata.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Michael Paquier <michael@paquier.xyz>, Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>

Date: 2022-10-05T18:57:16Z

Lists: pgsql-hackers

Attachments

fail_arch.patch (text/x-diff) patch

On Wed, Oct 05, 2022 at 07:55:58PM +0200, Peter Eisentraut wrote:
> Leaving archive_command empty is an intentional configuration choice.
> 
> What we are talking about here is, arguably, a misconfiguration, so it
> should result in an error.

Okay.  What do you think about something like the attached?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

Disallow setting archive_library and archive_command at the same time
- d627ce3b706d 16.0 landed
Restore archive_command documentation
- ba50834551f9 16.0 landed
- 5f56933ea5d5 15.0 landed
Doc: improve explanation of when custom GUCs appear in pg_settings.
- 44a51dc990cc 15.0 landed
- 857808a4116b 16.0 landed
doc: Add note about re-archiving of same WAL files in docs.
- 3cabe45a819f 16.0 cited
In basic_archive tests, insist on wal_level='replica'.
- 00c360a89c1a 15.0 landed
Allow archiving via loadable modules.
- 5ef1eefd76f4 15.0 landed
Move the code to archive files via the shell to a separate file.
- aeb4cc9ea07a 15.0 landed