Horton

Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: bharath.rupireddyforpostgres@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-10-04T06:41:30Z
Lists: pgsql-hackers 
At Tue, 04 Oct 2022 15:23:48 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> This is not directly related to this patch, pg_resetwal.c has the
> following line..
> 
> > static uint32 minXlogTli = 0;

I have found other three instances of this in xlog.c and
pg_receivewal.c.  Do they worth fixing?

(pg_upgarade.c has "uint32 tli/logid/segno but I'm not sure they need
 to be "fixed". At least the segno is not a XLogSegNo.)

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Use macros from xlog_internal.h for WAL segment logic in pg_resetwal

  2. Make WAL segment size configurable at initdb time.