Re: pgsql: Add 'basebackup_to_shell' contrib module.
Justin Pryzby <pryzby@telsasoft.com>
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@lists.postgresql.org, Magnus Hagander <magnus@hagander.net>
Date: 2022-03-26T03:13:53Z
Lists: pgsql-hackers
On Fri, Mar 25, 2022 at 02:27:07PM -0700, Andres Freund wrote: > On 2022-03-25 13:52:11 -0400, Robert Haas wrote: > > On Fri, Mar 25, 2022 at 12:36 PM Andres Freund <andres@anarazel.de> wrote: > > > Create a CF entry for it, or enable CI on a github repo? > > > > I created a CF entry for it. Then I had to try to Google around to > > find the URL from the cfbot, because it's not even linked from > > commitfest.postgresql.org for some reason. #blamemagnus I see it here (and in cfbot), although I'm not sure how you created a new patch for the active CF, and not for the next CF. https://commitfest.postgresql.org/37/ > > I don't think that the Windows CI is running the TAP tests for > > contrib. At least, I can't find any indication of it in the output. So > > it doesn't really help to assess how portable this test is, unless I'm > > missing something. > > Yea. It's really unfortunate how vcregress.pl makes it hard to run all > tests. And we're kind of stuck finding a way forward. It's easy enough to work > around for individual tests by just adding them to the test file (like Thomas > did nearby), but clearly that doesn't scale. Andrew wasn't happy with > additional vcregress commands. The fact that vcregress doesn't run tests in > parallel makes things take forever. And so it goes on. I have a patch to add alltaptests target to vcregress. But I don't recall hearing any objection to new targets until now. https://github.com/justinpryzby/postgres/runs/5174877506
Commits
-
Print information about type of test and subdirectory before running tests.
- 28bdfa2adfc6 15.0 landed
-
In basebackup_to_shell tests, properly set up pg_hba.conf.
- fea1cc49e4ab 15.0 landed
-
Add .gitignore for basebackup_to_shell.
- f8e0d900afed 15.0 landed
-
basebackup_to_shell: Add TAP test.
- 027fa0fd7261 15.0 landed
-
Document basebackup_to_shell.required_role.
- 26a0c025e233 15.0 landed
-
Add 'basebackup_to_shell' contrib module.
- c6306db24bd9 15.0 cited