Horton

Re: New Object Access Type hooks

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Mark Dilger <mark.dilger@enterprisedb.com>, Julien Rouhaud <rjuju123@gmail.com>, Joshua Brindle <joshua.brindle@crunchydata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Jeff Davis <pgsql@j-davis.com>, Joe Conway <joe@crunchydata.com>, Stephen Frost <sfrost@snowman.net>
Date: 2022-03-24T21:58:22Z
Lists: pgsql-hackers 
Hi,

On 2022-03-24 17:44:31 -0400, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > On 3/24/22 16:59, Andres Freund wrote:
> >> I just rebased the meson tree (atop 75b1521dae1) and the test_oat_hooks test
> >> fail on windows with meson.
> 
> > Even if you use NO_LOCALE=1/ENCODING=UTF8 as the Makefile now does?

I didn't do that, no. I guess I should have re-checked that in the makefile /
reread the commit message in more detail - although it really doesn't provide
a lot of that. That's, uh, some shoveling problems under the carpet.

I'll do that for now then.


> Note that that's basically a workaround for buggy placement of the
> OAT hooks, as per previous discussion.  I hope that we fix that bug
> pretty soon, so it shouldn't really be a factor for the meson conversion.

Yea. I found it's a lot easier to rebase the meson tree frequently rather than
do it in larger batches, so I just do so every few days...

Greetings,

Andres Freund

Commits

  1. Update some tests in 013_crash_restart.pl.

  2. Avoid freeing objects during json aggregate finalization

  3. SQL/JSON constructors

  4. Force NO_LOCALE / UTF8 for test_oat_hooks tests

  5. Temporarily disable installcheck for test_oat_hooks module

  6. Fix new Object Access hooks test

  7. Add String object access hooks

  8. Add a test module for Object Access hooks