Re: [PATCH] Accept IP addresses in server certificate SANs
Kyotaro Horiguchi <horikyota.ntt@gmail.com>
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: pchampion@vmware.com
Cc: pgsql-hackers@postgresql.org
Date: 2022-03-24T08:10:54Z
Lists: pgsql-hackers
At Wed, 23 Mar 2022 23:52:06 +0000, Jacob Champion <pchampion@vmware.com> wrote in
> On Wed, 2022-03-23 at 14:20 +0900, Kyotaro Horiguchi wrote:
> > I tried to write out the doc part. What do you think about it?
>
> I like it, thanks! I've applied that in v10, with a tweak to two
> iPAddress spellings and a short expansion of the condition in the Note,
> and I've added you as a co-author to 0002.
I'm fine with it. Thanks. I marked it as Ready-for-Commiter.
Note for the patch set:
0001 is preliminary patch to move inet_pton out of src/backend tree.
0002 is the main patch of this patchset
0003 is optional, which introduces pg_inet_pton() only works for IPv6
addresses. 0002 gets the same effect by the following use of
pg_inet_net_pton().
> if (!strchr(host, '/')
> && pg_inet_net_pton(PGSQL_AF_INET6, host, addr, -1) == 128)
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Commits
-
libpq: Allow IP address SANs in server certificates
- c1932e542863 15.0 landed
-
Add SSL tests for IP addresses in certificates
- af9e18049550 15.0 landed
-
Make JSON path numeric literals more correct
- e26114c817b6 15.0 cited