Horton

Re: cpluspluscheck vs ICU

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org, Peter Eisentraut <peter@eisentraut.org>
Date: 2022-03-23T02:23:23Z
Lists: pgsql-hackers

Attachments

Hi,

On 2022-03-22 17:20:24 -0700, Andres Freund wrote:
> I was about to propose adding headerscheck / cpluspluscheck to the CI file so
> that cfbot can catch future issues.

The attached patch does so, with ICU disabled to avoid the problems discussed
in the thread. Example run:
https://cirrus-ci.com/task/6326161696358400?logs=headers_headerscheck#L0

Unless somebody sees a reason not to, I'm planning to commit this soon.

Greetings,

Andres Freund

Commits

  1. Hide ICU C++ APIs from pg_locale.h

  2. ci: test headerscheck, cpluspluscheck as part of CompilerWarnings task.