Horton

Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: andres@anarazel.de
Cc: bharath.rupireddyforpostgres@gmail.com, ashu.coek88@gmail.com, sfrost@snowman.net, pgsql@j-davis.com, robertmhaas@gmail.com, andrew@dunslane.net, stark@mit.edu, schneider@ardentperf.com, bruce@momjian.us, pgsql-hackers@lists.postgresql.org, satyanarlapuram@gmail.com, marvin_liang@qq.com, actyzhang@outlook.com
Date: 2022-03-23T02:57:46Z
Lists: pgsql-hackers 
At Wed, 23 Mar 2022 11:51:25 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> The two places emit different outputs but the only difference is the
> delimiter between two blockrefs. (By the way, the current code forgets
> to insert a delimiter there).  So even if the function took "bool
> is_waldump", it is used only when appending a line delimiter.  It
> would be nicer if the "bool is_waldump" were "char *delimiter".
> Others might think differently, though..
> 
> So, the function looks like this.
> 
> StringInfo XLogBlockRefInfos(XLogReaderState *record, char *delimiter,
> 							uint32 &fpi_len);

By the way, xlog_block_info@xlogrecovery.c has the subset of the
function.  So the function can be shared with the callers of
xlog_block_info but I'm not sure it is not too-much...

StringInfo XLogBlockRefInfos(XLogReaderState *record, char *delimiter,
		   					bool fpw_detail, uint32 &fpi_len);

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Doc build fix: remove tab from filelist.sgml.

  2. Add contrib/pg_walinspect.

  3. Simplify SRFs using materialize mode in contrib/ modules

  4. Invent "trusted" extensions, and remove the pg_pltemplate catalog.