Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: Chapman Flack <chap@anastigmatix.net>
Cc: Stephen Frost <sfrost@snowman.net>, Magnus Hagander <magnus@hagander.net>, David Steele <david@pgmasters.net>, pgsql-hackers@lists.postgresql.org
Date: 2022-03-11T00:38:34Z
Lists: pgsql-hackers
Attachments
- v7-0001-remove-exclusive-backup-mode.patch (text/x-diff)
On Thu, Mar 10, 2022 at 07:13:14PM -0500, Chapman Flack wrote: > Looks like this change to an example in func.sgml is not quite right: > > -postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup()); > +postgres=# SELECT * FROM pg_walfile_name_offset(pg_backup_stop()); > > pg_backup_stop returns a record now, not just lsn. So this works for me: > > +postgres=# SELECT * FROM pg_walfile_name_offset((pg_backup_stop()).lsn); Ah, good catch. I made this change in v7. I considered doing something like this SELECT w.* FROM pg_backup_stop() b, pg_walfile_name_offset(b.lsn) w; but I think your suggestion is simpler. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
Commits
-
Remove duplicated word in comment of basebackup.c
- 83cca409edf2 15.0 landed