Horton

Re: Time to drop plpython2?

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, pgsql-hackers@postgresql.org
Date: 2022-03-08T19:03:18Z
Lists: pgsql-hackers 
Hi,

On 2022-03-08 13:49:15 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > A bit depressing to have a 500 line alternative output file for a one line
> > diff :(.
>
> Yeah.  How badly do we need that particular test case?

A bit hard to tell. The test was introduced in

commit 2bd78eb8d51cc9ee03ba0287b23ff4c266dcd9b9
Author: Peter Eisentraut <peter_e@gmx.net>
Date:   2011-04-06 22:36:06 +0300

    Add traceback information to PL/Python errors

    This mimics the traceback information the Python interpreter prints
    with exceptions.

    Jan Urbański

and contains this ominous line:

+/* AttributeError at toplevel used to give segfaults with the traceback
+*/

Greetings,

Andres Freund

Commits

  1. plpython: add missing plpython.h include to plpy_plpymodule.h

  2. plpython: Adjust docs after removal of Python 2 support.

  3. plpython: Code cleanup related to removal of Python 2 support.

  4. plpython: Remove regression test infrastructure for Python 2.

  5. plpython: Remove plpythonu, plpython2u and associated transform extensions.

  6. plpython: Reject Python 2 during build configuration.

  7. Add traceback information to PL/Python errors