Horton

Re: pg_tablespace_location() failure with allow_in_place_tablespaces

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: thomas.munro@gmail.com
Cc: michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Date: 2022-03-07T07:42:26Z
Lists: pgsql-hackers 
At Fri, 4 Mar 2022 23:26:43 +1300, Thomas Munro <thomas.munro@gmail.com> wrote in 
> On Fri, Mar 4, 2022 at 10:04 PM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
> > And I made a quick hack on do_pg_start_backup.  And I found that
> > pg_basebackup copies in-place tablespaces under the *current
> > directory*, which is not ok at all:(
> 
> Hmm.  Which OS are you on?  Looks OK here -- the "in place" tablespace
> gets copied as a directory under pg_tblspc, no symlink:

> The warning from readlink() while making the mapping file isn't ideal,
> and perhaps we should suppress that with something like the attached.
> Or does the missing map file entry break something on Windows?

Ah.. Ok, somehow I thought that pg_basebackup failed for readlink
failure and the tweak I made made things worse.  I got to make it
work.

Thanks!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Remove unnecessary Windows-specific basebackup code.

  2. Fix get_dirent_type() for Windows junction points.

  3. doc: Remove mention to in-place tablespaces for pg_tablespace_location()

  4. Fix pg_tablespace_location() with in-place tablespaces

  5. Fix pg_basebackup with in-place tablespaces.