Re: Frontend error logging style

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-02-24T15:03:11Z

Lists: pgsql-hackers

Hi,

On 2022-02-24 14:06:18 +0100, Peter Eisentraut wrote:
> My suggestion is to just get rid of pg_log_fatal() and replace them all with
> pg_log_error().

-1. This ignores that already several places came up with their slightly
different versions of fatal exit handlers. We don't gain anything by not
standardizing on one notion of a fatal error wrapper.

Greetings,

Andres Freund

Commits

logging: Also add the command prefix to detail and hint messages
- a8cca6026e99 15.0 landed
Remove not-very-useful early checks of __pg_log_level in logging.h.
- 2c9381840fe2 15.0 landed
Improve frontend error logging style.
- 9a374b77fb53 15.0 landed
Apply PGDLLIMPORT markings broadly.
- 8ec569479fc2 15.0 cited