Re: killing perl2host

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-02-16T21:01:41Z

Lists: pgsql-hackers

Hi,

On 2022-02-16 15:46:28 -0500, Andrew Dunstan wrote:
> I suggest that we apply this patch:

+1

> and if nothing breaks in a few days I will set about a more thorough
> removal of perl2host() and adjusting everywhere it's called, and we can
> forget that the whole sorry mess ever happened :-)

I think we would need an error check against using an msys perl when targeting
native windows, otherwise this'll be too hard to debug.

And we probably should set that environment variable that might fix in-tree
tests? Or reject in-tree builds?

Greetings,

Andres Freund

Commits

Remove PostgreSQL::Test::Utils::perl2host completely
- 95d981338b24 15.0 landed
- b30c62bd42eb 10.21 landed
- b4a6ceed52ee 11.16 landed
- 8358eacc954d 12.11 landed
- c27aa21e0dc8 13.7 landed
- 652ff988fbf6 14.3 landed
Remove most msys special processing in TAP tests
- 1c6d4629394d 15.0 landed
- f1f82301d6c5 11.16 landed
- aa8d4137f990 12.11 landed
- a5716baac00b 13.7 landed
- 8b5cd373ba03 14.3 landed
- 2b02cadb5cbc 10.21 landed
Ensure the right perl is used for TAP tests on msys
- cf12541f2bd5 15.0 landed
Disable perl2host() processing in TAP tests
- f1ac4a74dee5 15.0 landed