Horton

Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Thomas Munro <thomas.munro@gmail.com>, byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Heikki Linnakangas <heikki.linnakangas@iki.fi>, Michael Paquier <michael@paquier.xyz>
Date: 2022-02-15T00:55:06Z
Lists: pgsql-bugs 
Hi,

On 2022-02-14 19:48:00 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I was just writing a test to verify that the slot / stats bug you just
> > encountered is / stays fixed. I ended up doing it in isolationtester, because
> > that was the easiest to get reliable. When terminating an isolationtester
> > connection, I see the FATAL twice in isolationtester output:
> 
> Yeah, see
> 
> https://www.postgresql.org/message-id/flat/ab4288f8-be5c-57fb-2400-e3e857f53e46%40enterprisedb.com

Ah, thanks.

Is the generation of the duplicated error message reliable in case of a
pg_terminate_backend()? Kinda looks like it should be?

I guess I'll push the fix without a test for now...

Greetings,

Andres Freund

Commits

  1. Move libpq's write_failed mechanism down to pqsecure_raw_write().

  2. Fix thinko in PQisBusy().

  3. Set SNI ClientHello extension to localhost in tests

  4. Improve worst-case performance of text_position_get_match_pos()