Horton

Re: Add checkpoint and redo LSN to LogCheckpointEnd log message

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: masao.fujii@oss.nttdata.com
Cc: bharath.rupireddyforpostgres@gmail.com, nathandbossart@gmail.com, sfrost@snowman.net, bossartn@amazon.com, rjuju123@gmail.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Date: 2022-02-14T05:52:15Z
Lists: pgsql-hackers

Attachments

At Mon, 14 Feb 2022 14:42:18 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> I'll resend new version soon to avoid the confusion..

In this version , 0001 gets one fix and two comment updates.

-		 * Archive recovery have ended. Crash recovery ever after should always
+		 * Archive recovery has ended. Crash recovery ever after should always

-	/* the second term is just in case */
-	if (PriorRedoPtr != InvalidXLogRecPtr || RedoRecPtr > PriorRedoPtr)
+ 	/*
+ 	 * Update the average distance between checkpoints/restartpoints if the
+	 * prior checkpoint exists. The second term is just in case.
+ 	 */
+	if (PriorRedoPtr != InvalidXLogRecPtr && RedoRecPtr > PriorRedoPtr)
 		UpdateCheckPointDistanceEstimate(RedoRecPtr - PriorRedoPtr);

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Add checkpoint and REDO LSN to log_checkpoints message.