Re: New developer papercut - Makefile references INSTALL

Hi,

On 2022-02-09 22:32:59 +0100, Magnus Hagander wrote:
> On Fri, Jan 21, 2022 at 11:53 PM Andres Freund <andres@anarazel.de> wrote:
> > On 2022-01-21 17:25:08 -0500, Tom Lane wrote:
> > > Perhaps this could be finessed by making updating of INSTALL
> > > the responsibility of some post-commit hook on the git server.
> > > Not sure that we want to go there, though.  In any case, that
> > > approach would negate your point about seeing the results.
> >
> > It would. I guess it'd still be better than the situation today, but...
> 
> post-commit hooks don't run on the git server, they run locally on
> your machine. There is a "post receive" hook that runs on the git
> server, but we definitely don't want that one to fabricate new commits
> I think.

Why not? We probably wouldn't want to do synchronously as part of the receive
hook, but if we have a policy that INSTALL is not to be updated by humans, but
updated automatically whenever its sources are modified, I'd be OK with
auto-committing that.


But before we go there, it might be worth checking if the generated INSTALL
actually changes meaningfully across "doc toolchain" versions. If not, a
simpler receive hook verifying that INSTALL was updated when the relevant sgml
files changed probably would be sufficient.

Greetings,

Andres Freund