Re: Fix CheckIndexCompatible comment
Yugo Nagata <nagata@sraoss.co.jp>
From: Yugo NAGATA <nagata@sraoss.co.jp>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Date: 2022-02-07T10:14:18Z
Lists: pgsql-hackers
Attachments
- v2_fix_CheckIndexCompatible_comment.patch (text/x-diff) patch v2
Hello, Fujii-san, On Fri, 4 Feb 2022 09:08:22 +0900 Fujii Masao <masao.fujii@oss.nttdata.com> wrote: > > > On 2022/02/04 1:46, Yugo NAGATA wrote: > > Hello, > > > > I found a old parameter name 'heapRelation' in the comment > > of CheckIndexCompatible. This parameter was removed by 5f173040. > > > > Attached is a patch to remove it from the comment. > > Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"? Agreed. I updated the patch to add a comment about 'oldId'. Regards, Yugo Nagata -- Yugo NAGATA <nagata@sraoss.co.jp>
Commits
-
Fix comment in CheckIndexCompatible().
- f927a6ec3ef7 15.0 landed