Horton

Re: GUC flags

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@lists.postgresql.org, bruce@momjian.us, tgl@sss.pgh.pa.us
Date: 2022-02-07T03:04:14Z
Lists: pgsql-hackers 
Thanks for working on it.

Your test is checking that stuff in sample.conf is actually a GUC and not
marked NOT_IN_SAMPLE.  But those are both unlikely mistakes to make.

The important/interesting test is the opposite: that all GUCs are present in
the sample file.  It's a lot easier for someone to forget to add a GUC to
sample.conf than it is for someone to accidentally add something that isn't a
GUC.

I'd first parse the GUC-like lines in the file, making a list of gucs_in_file
and then compare the two lists.

-- 
Justin

Commits

  1. Add TAP test to automate the equivalent of check_guc, take two

  2. Retire src/backend/utils/misc/check_guc

  3. Add TAP test to automate the equivalent of check_guc

  4. Add PostgreSQL::Test::Cluster::config_data()

  5. Introduce pg_settings_get_flags() to find flags associated to a GUC

  6. Revert changes about warnings/errors for placeholders.

  7. Improve the description of various GUCs