Horton

Re: Fix CheckIndexCompatible comment

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Yugo NAGATA <nagata@sraoss.co.jp>, pgsql-hackers@postgresql.org
Date: 2022-02-04T00:14:53Z
Lists: pgsql-hackers 
On Fri, Feb 04, 2022 at 09:08:22AM +0900, Fujii Masao wrote:
> On 2022/02/04 1:46, Yugo NAGATA wrote:
>> I found a old parameter name 'heapRelation' in the comment
>> of CheckIndexCompatible. This parameter was removed by 5f173040.
>> 
>> Attached is a patch to remove it from the comment.

It looks like this parameter was removed in 5f17304.
 
> Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"?

+1

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Commits

  1. Fix comment in CheckIndexCompatible().