Re: Windows crash / abort handling

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Craig Ringer <craig.ringer@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-02-03T02:38:00Z
Lists: pgsql-hackers
Hi,

On 2022-02-02 11:24:19 +1300, Thomas Munro wrote:
> On Sun, Jan 30, 2022 at 10:02 AM Andres Freund <andres@anarazel.de> wrote:
> > On 2022-01-09 16:57:04 -0800, Andres Freund wrote:
> > > I've attached a patch implementing these changes.
> >
> > Unless somebody is planning to look at this soon, I'm planning to push it to
> > master. It's too annoying to have these hangs and not see backtraces.
> 
> +1, I don't know enough about Windows development to have an opinion
> on the approach but we've got to try *something*, these hangs are
> terrible.

I've pushed the patch this thread is about now. Lets see what the buildfarm
says. I only could one windows version.  Separately I've also pushed a patch
to run the windows tests under a timeout. I hope in combination these patches
address the hangs.

Greetings,

Andres Freund



Commits

  1. windows: Improve crash / assert / exception handling.

  2. ci: windows: run tests under timeout.

  3. Prevent Win32 from displaying a popup box on backend crash. Instead let