Horton

Re: Ensure that STDERR is empty during connect_ok

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jacob Champion <pchampion@vmware.com>
Date: 2022-02-02T16:24:09Z
Lists: pgsql-hackers 
On 2022-Feb-02, Andrew Dunstan wrote:

> On 2/2/22 11:01, Dagfinn Ilmari Mannsåker wrote:

> > Rather than waiting for Someone™ to find a suitably-shaped tuit to do a
> > whole sweep converting everything to done_testing(), I think we should
> > make a habit of converting individual scripts whenever a change breaks
> > the count.

+1.

> Or when anyone edits a script, even if the number of tests doesn't get
> broken.

Sure, if the committer is up to doing it, but let's not make that a hard
requirement for any commit that touches a test script.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Ni aún el genio muy grande llegaría muy lejos
si tuviera que sacarlo todo de su propio interior" (Goethe)

Commits

  1. Ensure that STDERR is empty in connect_ok tests

  2. Require version 0.98 of Test::More for TAP tests