Re: Ensure that STDERR is empty during connect_ok
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jacob Champion <pchampion@vmware.com>
Date: 2022-02-02T15:48:22Z
Lists: pgsql-hackers
On 2022-Feb-02, Daniel Gustafsson wrote: > Making this a subtest in order to not having to change the callers, turns the > patch into the attached. For this we must group the new test with one already > existing test, if we group more into it (which would make more sense) then we > need to change callers as that reduce the testcount across the tree. Well, it wasn't my intention that this patch would not have to change the callers. What I was thinking about is making connect_ok() have a subtest for *all* the tests it contains (and changing the callers to match), so that *in the future* we can add more tests there without having to change the callers *again*. > Or did I misunderstand you? I think you did. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Cómo ponemos nuestros dedos en la arcilla del otro. Eso es la amistad; jugar al alfarero y ver qué formas se pueden sacar del otro" (C. Halloway en La Feria de las Tinieblas, R. Bradbury)
Commits
-
Ensure that STDERR is empty in connect_ok tests
- 4d373e05286d 15.0 landed
-
Require version 0.98 of Test::More for TAP tests
- 405f32fc4960 15.0 cited