Horton

Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included

Julien Rouhaud <rjuju123@gmail.com>

View thread View on postgr.es
From: Julien Rouhaud <rjuju123@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-30T14:49:12Z
Lists: pgsql-hackers 
Hi,

On Sun, Jan 30, 2022 at 06:52:48PM +0530, Bharath Rupireddy wrote:
> 
> Here's the v3 patch removing xloginsert.h from xlog.h and adding
> xloginsert.h in the required files.

+1, this approach is better.  In general it's better to increase the number of
include lines rather than having a few that includes everything, for
compilation performance.

Commits

  1. Remove xloginsert.h from xlog.h

  2. Revamp the WAL record format.

  3. Move the backup-block logic from XLogInsert to a new file, xloginsert.c.