Horton

Re: fairywren is generating bogus BASE_BACKUP commands

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-24T00:13:10Z
Lists: pgsql-hackers 
Hi,

On 2022-01-23 17:38:26 -0500, Andrew Dunstan wrote:
> Nice idea. I have a suspicion that it's going to be harder than you
> think, but I'll be very happy to be proved wrong.

FWIW, a manual invocation of the pg_basebackup tests works via a ucrt perl
(ucrt64/mingw-w64-ucrt-x86_64-perl package).

It did require installing IPC::Run via cpan though, or at least I think it
did. That's a bit annoying. But not all that onerous if we document it?

I did make sure that the ucrt perl deals with windows paths. For good measure
I forced an early return in perl2host.


I think we would have to modify the values for a few environment
variables. Stuff like PG_REGRESS, TAR etc. Either where we specify them, or
Utils.pm or such.

Greetings,

Andres Freund

Commits

  1. Remove PostgreSQL::Test::Utils::perl2host completely

  2. Unbreak pg_basebackup/t/010_pg_basebackup.pl on msys

  3. On Windows, also call shutdown() while closing the client socket.

  4. On Windows, close the client socket explicitly during backend shutdown.