Horton

Re: [PATCH] reduce page overlap of GiST indexes built using sorted method

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: "sergei sh." <sshoulbakov@kontur.io>
Cc: Aliaksandr Kalenik <akalenik@kontur.io>, pgsql-hackers@lists.postgresql.org
Date: 2022-01-23T22:17:15Z
Lists: pgsql-hackers 
Hi,

On 2022-01-18 23:26:05 +0300, sergei sh. wrote:
> I've addressed Andrey Borodin's concerns about v2 of this patch by
> Aliaksandr
> Kalenik in attached version. Change list:
> * Number of pages to collect moved to GUC parameter
> "gist_sorted_build_page_buffer_size".
> * GistSortedBuildPageState type renamed to GistSortedBuildLevelState.
> * Comments added.

Unfortunately the tests don't seem to pass on any platform, starting with this
version:
https://cirrus-ci.com/build/4808414281859072

Presumably the fault of v1-amcheck-gist-no-btree.patch, which comments out
some functions. I assume that patch isn't intended to be part of the
submission?

https://wiki.postgresql.org/wiki/Cfbot#Which_attachments_are_considered_to_be_patches.3F

Greetings,

Andres Freund

Commits

  1. Reduce non-leaf keys overlap in GiST indexes produced by a sorted build