Horton

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: rjuju123@gmail.com
Cc: pgsql-hackers@postgresql.org
Date: 2022-01-17T08:24:43Z
Lists: pgsql-hackers 
At Sun, 16 Jan 2022 12:43:03 +0800, Julien Rouhaud <rjuju123@gmail.com> wrote in 
> Hi,
> 
> On Fri, Dec 24, 2021 at 07:21:59PM +0900, Kyotaro Horiguchi wrote:
> > Just a complaint..
> > 
> > At Fri, 12 Nov 2021 16:43:27 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> > > "<JUNCTION>" on Japanese (CP-932) environment. I didn't actually
> > > tested it on Windows and msys environment ...yet.
> > 
> > Active perl cannot be installed because of (perhaps) a powershell
> > version issue... Annoying..
> > 
> > https://community.activestate.com/t/please-update-your-powershell-install-scripts/7897
> 
> I'm not very familiar with windows, but maybe using strawberry perl instead
> ([1]) would fix your problem?  I think it's also quite popular and is commonly
> used to run pgBadger on Windows.

Thanks! I'll try it later.

> Other than that, I see that the TAP tests are failing on all the environment,
> due to Perl errors.  For instance:
> 
> [04:06:00.848] [04:05:54] t/003_promote.pl .....
> [04:06:00.848] Dubious, test returned 2 (wstat 512, 0x200)
> https://api.cirrus-ci.com/v1/artifact/task/4751213722861568/tap/src/bin/pg_basebackup/tmp_check/log/regress_log_020_pg_receivewal
> # Initializing node "standby" from backup "my_backup" of node "primary"
> Odd number of elements in hash assignment at /tmp/cirrus-ci-build/src/bin/pg_ctl/../../../src/test/perl/PostgreSQL/Test/Cluster.pm line 996.
> Use of uninitialized value in list assignment at /tmp/cirrus-ci-build/src/bin/pg_ctl/../../../src/test/perl/PostgreSQL/Test/Cluster.pm line 996.
> Use of uninitialized value $tsp in concatenation (.) or string at /tmp/cirrus-ci-build/src/bin/pg_ctl/../../../src/test/perl/PostgreSQL/Test/Cluster.pm line 1008.
> Use of uninitialized value $tsp in concatenation (.) or string at /tmp/cirrus-ci-build/src/bin/pg_ctl/../../../src/test/perl/PostgreSQL/Test/Cluster.pm line 1009.
> 
> That's apparently the same problem on every failure reported.
> 
> Can you send a fixed patchset?  In the meantime I will switch the cf entry to
> Waiting on Author.

I guess that failure came from a recent change that allows in-place
tablespace directory.  I'll check it out.  Thanks!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Improve recently-added test reliability

  2. Fix new recovery test for log_error_verbosity=verbose case

  3. Fix test instability

  4. Fix replay of create database records on standby

  5. Allow "in place" tablespaces.

  6. Fix get_dirent_type() for Windows junction points.

  7. Revert "Fix replay of create database records on standby"

  8. Add end-to-end testing of pg_basebackup's tar-format output.

  9. Make DROP DATABASE command generate less WAL records.

  10. Consolidate methods for translating a Perl path to a Windows path.