Horton

Re: Null commitTS bug

Kyotaro Horiguchi <horikyota.ntt@gmail.com>

View thread View on postgr.es
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: kingsboa@amazon.com
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-01-17T02:17:24Z
Lists: pgsql-hackers 
At Fri, 14 Jan 2022 22:49:59 +0000, "Kingsborough, Alex" <kingsboa@amazon.com> wrote in 
> The fix for this is very simple
> 
> 
>   /* if we wrote out all subxids, we're done. /
>   - if (j + 1 >= nsubxids)
>   + if (j >= nsubxids)
>   break;

It looks like a thinko and the fix is correct. (It's a matter of taste
choosing between it and "j == nsubxids").

I found some confusing lines around but they need not a fix
considering back-patching conflict?

> for (i = 0, headxid = xid;;)
..
> i += j - i + 1;

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Fix one-off bug causing missing commit timestamps for subtransactions