Horton

Re: SKIP LOCKED assert triggered

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Simon Riggs <simon.riggs@enterprisedb.com>, "Bossart, Nathan" <bossartn@amazon.com>, pgsql-hackers@postgresql.org
Date: 2022-01-04T16:55:59Z
Lists: pgsql-hackers 
On Tue, Jan 04, 2022 at 11:15:30AM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Pushed, thanks Simon for reporting this problem.
> 
> Umm ...
> 
>        Assert(TM_WouldBlock || !(tuple->t_data->t_infomask & HEAP_XMAX_INVALID));
> 
> AFAICS, this assertion condition is constant-true,

The new cfbot was failing like this

https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/36/3423
https://cirrus-ci.com/build/5839382107127808
[22:52:27.978] heapam.c:4754:24: error: converting the enum constant to a boolean [-Werror,-Wint-in-bool-context]

Commits

  1. Allow special SKIP LOCKED condition in Assert()