Horton

Thread

Commits

  1. Use MaxLockMode symbol in more places.

  1. Use MaxLockMode in lock methods initialization

    Julien Rouhaud <rjuju123@gmail.com> — 2022-01-03T06:47:22Z

    Hi,

While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
but didn't update the lock methods initialization.  It shouldn't make much
difference in the long run but some consistency seems better to me.

  2. Re: Use MaxLockMode in lock methods initialization

    Michael Paquier <michael@paquier.xyz> — 2022-01-03T08:00:13Z

    On Mon, Jan 03, 2022 at 02:47:22PM +0800, Julien Rouhaud wrote:
> While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
> but didn't update the lock methods initialization.  It shouldn't make much
> difference in the long run but some consistency seems better to me.

Makes sense to me.  MaxLockMode is here for the same purpose as this
initialization area.
--
Michael

  3. Re: Use MaxLockMode in lock methods initialization

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-01-03T17:27:18Z

    Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jan 03, 2022 at 02:47:22PM +0800, Julien Rouhaud wrote:
>> While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
>> but didn't update the lock methods initialization.  It shouldn't make much
>> difference in the long run but some consistency seems better to me.

> Makes sense to me.  MaxLockMode is here for the same purpose as this
> initialization area.

Agreed.  That aspect of b04aeb0a053e7 was a bit of a quick hack,
and it didn't occur to me to look for other places where the symbol
could be used.  But these two places are spot-on for it.

Pushed with a bit of comment-fiddling.

			regards, tom lane