Horton
Menu

Re: tweak to a few index tests to hits ambuildempty() routine.

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: a.kozhemyakin@postgrespro.ru, Noah Misch <noah@leadboat.com>, Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, thomas.munro@gmail.com
Date: 2022-09-25T15:57:07Z
Lists: pgsql-hackers 
On 2022-Sep-25, Tom Lane wrote:

> That's what it's saying *now*, but after rereading this whole thread
> I see that it apparently said something different last week.  So the
> coverage is probabilistic, which squares with this discussion and
> with some tests I just did locally.  That's not good.

Completely agreed.

> I propose that we revert 4fb5c794e and instead add separate test
> cases that just create unlogged indexes (I guess they don't actually
> need to *do* anything with them?).

WFM.  I can do it next week, or feel free to do so if you want.

> Looks like dec8ad367 could be reverted as well, in view of 2f2e24d90.

Yeah, sounds good.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid loss of code coverage with unlogged-index test cases.

  2. Use --no-unlogged-table-data in t/027_stream_regress.pl.

  3. Cover brin/gin/gist/spgist ambuildempty routines in regression tests

  4. Improve test coverage of ginvacuum.c.