Horton

Re: [RFC] building postgres with meson - v13

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>, Thomas Munro <thomas.munro@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>
Cc: samay sharma <smilingsamay@gmail.com>, Nazir Bilal Yavuz <byavuz81@gmail.com>, pgsql-hackers@postgresql.org
Date: 2022-09-21T16:46:30Z
Lists: pgsql-hackers

Attachments

Hi,

On 2022-09-19 19:16:30 -0700, Andres Freund wrote:
> On 2022-09-19 05:25:59 -0400, Peter Eisentraut wrote:
> > IMO, the following commits are ready to be pushed now:
> 
> Slowly working through them.

I've attached an updated version of the main meson commit (and pushed all of
them to my git tree obviously). Changes:

- Added a longer commit message
- Stopped building doc/src/sgml/postgres-full.xml by default - somehow I
  thought we did so by default for the autoconf build, but that's not the
  case. Thomas noticed that that was extremely slow on one of his machines,
  which turns out to be because it's downloading the dtd's.
- Added a missing dependency on check_rules.pl's result, lost that in a
  cleanup, oops
- Fixed a few typos, via codespell

I'm planning to commit this today, unless somebody wants to argue against
that.


After that I am planning to split the "ci" commit so that it converts a few of
the CI tasks to use meson, without adding all the other platforms I added for
development. I think that's important to get in soon, given that it'll
probably take a bit until the buildfarm grows meson coverage and because it
provides cfbot coverage which seems important for now as well.

I think we should:

- convert windows to build with ninja - it builds faster, runs all tests,
  parallelizes tests. That means that msbuild based builds don't have coverage
  via CI / cfbot, but we don't currently have the resources to test both.
- add a linux build using meson, we currently can afford building both with
  autoconf and meson for linux

I'm less clear on whether we should convert macos / freebsd to meson at this
point?

Greetings,

Andres Freund

Commits

  1. meson: Add 'running' test setup, as a replacement for installcheck

  2. meson: Add support for building with precompiled headers

  3. windows: Adjust FD_SETSIZE via commandline define

  4. meson: docs: Add xml{lint,proc} wrapper to collect dependencies

  5. meson: ecpg: Split definition of static and shared libraries

  6. windows: Set UMDF_USING_NTSTATUS globally, include ntstatus.h

  7. ci: Add hint about downloadable logs to README

  8. meson: Set up absolute rpaths to libdir

  9. meson: Include CFLAGS/c_args in summary and pg_config output

  10. windows: remove date from version number in win32ver.rc

  11. meson: Add initial version of meson based build system

  12. ci: windows: set error mode to not include SEM_NOGPFAULTERRORBOX

  13. Refactor PG_TEST_EXTRA logic in autoconf build

  14. Split TESTDIR into TESTLOGDIR and TESTDATADIR

  15. Don't hardcode tmp_check/ as test directory for tap tests

  16. Extend gendef.pl in preparation for meson

  17. Include c.h instead of postgres.h in src/port/*p{read,write}*.c

  18. Remove DLLTOOL, DLLWRAP from configure / Makefile.global.in

  19. Run xmllint validation only once

  20. Bump minimum Perl version to 5.14

  21. Move gramparse.h to src/backend/parser

  22. Run perltidy over Catalog.pm

  23. Parse catalog .dat files as a whole when compiling the backend

  24. Build all Flex files standalone

  25. Move private declarations shared between guc.c and guc-file.l to new header

  26. Preparatory refactoring for compiling guc-file.c standalone

  27. Move darwin sysroot determination into separate file

  28. Fix MSVC warning in compat_informix/rnull.pgc

  29. solaris: Use versioning scripts instead of -Bsymbolic

  30. Change shared library installation naming on macOS

  31. regress: allow to specify directory containing expected files, for ecpg

  32. Don't add HAVE_LDAP_H HAVE_WINLDAP_H to pg_config.h

  33. Refactor dtrace postprocessing make rules

  34. Add output directory option to gen_node_support.pl

  35. Add output directory argument to generate-unicode_norm_table.pl

  36. Add output file argument to generate-errcodes.pl

  37. Add output path arg in generate-lwlocknames.pl

  38. Move snowball_create.sql creation into perl file

  39. ecpg: Output dir, source dir, stamp file argument for preproc/*.pl

  40. psql: Output dir and dependency generation for sql_help

  41. Deal with paths containing \ and spaces in basebackup_to_shell tests

  42. Remove LLVM_CONFIG from Makefile.global.in

  43. Make update-unicode target work in vpath builds

  44. Refactor DLSUFFIX handling

  45. ldap tests: Add paths for openbsd.

  46. ldap tests: Don't run on unsupported operating systems.

  47. Remove check for accept() argument types

  48. Move our p{read,write}v replacements into their own files.

  49. Adjust yywrap macro for non-reentrant scanners for MSVC.

  50. Remove any -arch switches given in ExtUtils::Embed's ldopts from our

  51. Change PL/Perl and Pg interface build to use configured compiler and

  52. Apparently, on some systems, ExtUtils::Embed and MakeMaker are slightly