Horton

Re: [PATCH]Feature improvement for MERGE tab completion

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: bt22kawamotok <bt22kawamotok@oss.nttdata.com>, Shinya Kato <Shinya11.Kato@oss.nttdata.com>, pgsql-hackers@postgresql.org
Date: 2022-09-21T10:40:00Z
Lists: pgsql-hackers 
On 2022-Sep-21, Fujii Masao wrote:

> How about adding something like PartialMatches() that checks whether
> the keywords are included in the input string or not? If so, we can restrict
> some tab-completion rules to operating only on MERGE, as follows. I attached
> the WIP patch (0002 patch) that introduces PartialMatches().
> Is this approach over-complicated? Thought?

I think it's fine to backpatch your 0001 to 15 and put 0002 in master.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"I can't go to a restaurant and order food because I keep looking at the
fonts on the menu.  Five minutes later I realize that it's also talking
about food" (Donald Knuth)

Commits

  1. Push lpp variable closer to usage in heapgetpage()

  2. psql: Improve tab-completion for MERGE.