Re: pgsql: Prefetch data referenced by the WAL, take II.

Alvaro Herrera <alvherre@alvh.no-ip.org>

From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Thomas Munro <tmunro@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-13T10:07:40Z
Lists: pgsql-hackers
On 2022-Sep-13, Thomas Munro wrote:

> I'd go for your second suggestion.  'therein' doesn't convey much (we
> already said 'in the WAL', and therein is just a slightly formal and
> somehow more Germanic way of saying 'in it' which is kinda
> duplicative; maybe 'by it' is what we want but that's still kinda
> implied already), whereas adding 'data' makes it slightly clearer that
> it's blocks from relations and not, say, the WAL itself.
> 
> Also, hmm, it's not really the 'Maximum buffer size', it's the 'Buffer size'.

Sounds reasonable.  Pushed these changes.  Thank you!

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)



Commits

  1. Improve wal_decode_buffer_size description some more

  2. Include some missing headers.

  3. Prefetch data referenced by the WAL, take II.