Horton

Re: fix stats_fetch_consistency value in postgresql.conf.sample

Justin Pryzby <pryzby@telsasoft.com>

View thread View on postgr.es
From: Justin Pryzby <pryzby@telsasoft.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz, andres@anarazel.de, nathandbossart@gmail.com, pgsql-hackers@postgresql.org
Date: 2022-09-13T00:43:03Z
Lists: pgsql-hackers 
Hi,

Checking if you're planning to work on this patch still ?

On Thu, Jul 28, 2022 at 05:27:34PM -0500, Justin Pryzby wrote:
> Note that this can currently exposes internal elog() errors to users:
> 
> postgres=# select pg_normalize_config_value('log_min_messages','abc');
> WARNING:  invalid value for parameter "log_min_messages": "abc"
> HINT:  Available values: debug5, debug4, debug3, debug2, debug1, info, notice, warning, error, log, fatal, panic.
> ERROR:  could not find enum option 0 for log_min_messages
> 
> postgres=# \errverbose
> ERROR:  XX000: could not find enum option 0 for log_min_messages
> LOCATION:  config_enum_lookup_by_value, guc.c:7284

Commits

  1. Align stats_fetch_consistency definition with guc.c default.

  2. Fix stats_fetch_consistency default value indicated in postgresql.conf.sample.