Re: pgsql: Prefetch data referenced by the WAL, take II.
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-09-04T07:54:50Z
Lists: pgsql-hackers
On 2022-Apr-07, Thomas Munro wrote:
> Prefetch data referenced by the WAL, take II.
I propose a small wording change in guc.c,
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 9fbbfb1be5..9803741708 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -2840,7 +2840,7 @@ static struct config_int ConfigureNamesInt[] =
{
{"wal_decode_buffer_size", PGC_POSTMASTER, WAL_RECOVERY,
gettext_noop("Maximum buffer size for reading ahead in the WAL during recovery."),
- gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch referenced blocks."),
+ gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch data blocks referenced therein."),
GUC_UNIT_BYTE
},
&wal_decode_buffer_size,
"referenced blocks" seems otherwise a bit unclear to me. Other wording
suggestions welcome. I first thought of "...to prefetch referenced data
blocks", which is probably OK too.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)
Commits
-
Improve wal_decode_buffer_size description some more
- 8e7a0b4a3674 16.0 landed
- 892cac912499 15.0 landed
-
Include some missing headers.
- 5b186308fbc4 15.0 landed
-
Prefetch data referenced by the WAL, take II.
- 5dc0418fab28 15.0 cited