Re: [PATCH] Add native windows on arm64 support
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Niyas Sait <niyas.sait@linaro.org>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-30T00:33:56Z
Lists: pgsql-hackers
Hi, On 2022-08-29 19:58:31 -0400, Tom Lane wrote: > Michael Paquier <michael@paquier.xyz> writes: > > This is amazing. The issue has showed up a second time in a row in > > bowerbird, as of: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2022-08-29%2013%3A30%3A32 > > That is fascinating. > > I don't know what to think about ASLR that manipulates the comment in > > this XML object under VS 2017 (perhaps a compiler issue?), but it > > should be possible to go back to green simply by removing "<!--c1-->" > > from the input string. Creating an extra output pattern here would be > > very costly, as xml_2.out and xml.out have outputs for --with-libxml. > > > Would people object if I do that for now? > > Let's let it go for a few more runs. I want to know whether it > reproduces 100% or only sometimes. The weirdest part is that it only happens as part of the the pg_upgrade test. I just tested it in my test windows vm (win 10, vs 2019), with a build of libxml I had around (2.9.7), and the regression tests passed both "normally" and within pg_upgrade. Greetings, Andres Freund
Commits
-
MSVC: Support building for AArch64.
- a516b3f00d74 19 (unreleased) landed
-
Remove "#ifdef WIN32" guards from src/port/win32*.c
- 09eb633e1baa 17.0 cited
-
Adjust XML test case to avoid unstable behavior.
- 4ea07e7cf3c6 16.0 landed
-
Enable RandomizedBaseAddress (ASLR) on Windows with MSVC builds
- 36389a060ca6 16.0 landed