Re: windows cfbot failing: my_perl
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@enterprisedb.com>, Andrew Dunstan <andrew@dunslane.net>, Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@gmail.com>
Date: 2022-08-27T07:11:13Z
Lists: pgsql-hackers
On 2022-08-26 23:02:06 -0400, Tom Lane wrote: > John Naylor <john.naylor@enterprisedb.com> writes: > > On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <andres@anarazel.de> wrote: > >> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the > >> include in plperl.h would keep that aspect transparent, because plperl_utils.h > >> includes plperl.h. > > > Since plperl_helpers.h already includes plperl.h, I'm not sure why > > both are included everywhere the former is. If .c/.xs files didn't > > include plperl.h directly, we could keep pg_wchar.h in > > plperl_helpers.h. Not sure if that's workable or any better... > > Maybe we should flush the separate plperl_helpers.h header and just > put those static-inline functions in plperl.h. +1
Commits
-
Be more careful to avoid including system headers after perl.h
- 4eec2e03c34f 16.0 landed
-
Use SSE2 in is_valid_ascii() where available.
- 121d2d3d70ec 16.0 cited