Re: archive modules
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: talk to ben <blo.talkto@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Robert Haas <robertmhaas@gmail.com>, "Bossart, Nathan" <bossartn@amazon.com>, David Steele <david@pgmasters.net>, Fujii Masao <masao.fujii@oss.nttdata.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Michael Paquier <michael@paquier.xyz>, Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>
Date: 2022-08-23T17:39:30Z
Lists: pgsql-hackers
On Tue, Aug 23, 2022 at 04:18:52PM +0200, talk to ben wrote: > --- a/doc/src/sgml/basic-archive.sgml > +++ b/doc/src/sgml/basic-archive.sgml > @@ -68,6 +68,19 @@ basic_archive.archive_directory = '/path/to/archive/directory' > to any archiving still in progress, but users should use extra caution when > doing so. > </para> > + > + <para> > + The archive module is loaded by the archiver process. Therefore, the > + parameters defined in the module are not set outside this process and cannot > + be seen from the <structname>pg_settings</structname> view or the > + \dconfig meta-command. > + These parameters values can be shown from the server's configuration > + file(s) through the <structname>pg_file_settings</structname> view. > + If you want to check the actual values applied by the archiver, you can > + <command>LOAD</command> the module before reading > + <structname>pg_settings</structname>. It's also possible to search > + for the options directly with the <command>SHOW</command> command. > + </para> I don't know if it makes sense to document this in basic_archive. On one hand, it seems like folks will commonly encounter this behavior with this module, so this feels like a natural place for such a note. But on the other hand, this is generic behavior for any library that is dynamically loaded in a separate process. Overall, I think I'm +1 for this patch. I haven't thought too much about the exact wording, but provided others support it as well, I will try to take a deeper look soon. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
Commits
-
Disallow setting archive_library and archive_command at the same time
- d627ce3b706d 16.0 landed
-
Restore archive_command documentation
- ba50834551f9 16.0 landed
- 5f56933ea5d5 15.0 landed
-
Doc: improve explanation of when custom GUCs appear in pg_settings.
- 44a51dc990cc 15.0 landed
- 857808a4116b 16.0 landed
-
doc: Add note about re-archiving of same WAL files in docs.
- 3cabe45a819f 16.0 cited
-
In basic_archive tests, insist on wal_level='replica'.
- 00c360a89c1a 15.0 landed
-
Allow archiving via loadable modules.
- 5ef1eefd76f4 15.0 landed
-
Move the code to archive files via the shell to a separate file.
- aeb4cc9ea07a 15.0 landed