Horton

Re: [HACKERS] [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>, pgsql-committers@postgresql.org
Date: 2022-08-13T19:08:43Z
Lists: pgsql-hackers 
Hi Noah,

On 2017-10-13 11:24:05 -0700, Andres Freund wrote:
> On 2017-10-13 14:19:22 -0400, Tom Lane wrote:
> > > So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=yes, set
> > > at the same place, that's then tested before running the relevant
> > > configure check?
> > 
> > +1.  I think you don't actually have to skip the configure check,
> > and there might be some value in letting it carry on normally
> > (so that "restrict" is set properly).  We'd just want it to affect
> > what pg_restrict gets defined as.  Something like
> 
> > if test "$ac_cv_c_restrict" = "no" -o "x$FORCE_DISABLE_RESTRICT" = "xyes"; then
> >   pg_restrict=""
> > else
> >   pg_restrict="$ac_cv_c_restrict"
> 
> Yea, that works. Will make it so.

Any chance you could check if this is still needed? I've a FIXME about it in
the meson code that I'd like to get rid of :)

Greetings,

Andres Freund

Commits

  1. Force "restrict" not to be used when compiling with xlc.

  2. Rely on sizeof(typename) rather than sizeof(variable) in pqformat.h.

  3. Use C99 restrict via pg_restrict, rather than restrict directly.

  4. Improve performance of SendRowDescriptionMessage.

  5. Partially flatten struct tupleDesc so that it can be used in DSM.

  6. Remove useless duplicate inclusions of system header files.