Horton

Thread

Commits

  1. Use SetInstallXLogFileSegmentActive() in more places in xlog.c

  1. Use SetInstallXLogFileSegmentActive() for setting XLogCtl->InstallXLogFileSegmentActive

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2022-08-11T16:12:18Z

    Hi,

Here's a small patch replacing the explicit setting of
XLogCtl->InstallXLogFileSegmentActive with the existing function
SetInstallXLogFileSegmentActive(), removes duplicate code and saves 4
LOC.

-- 
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/

  2. Re: Use SetInstallXLogFileSegmentActive() for setting XLogCtl->InstallXLogFileSegmentActive

    Nathan Bossart <nathandbossart@gmail.com> — 2022-08-11T22:47:00Z

    On Thu, Aug 11, 2022 at 09:42:18PM +0530, Bharath Rupireddy wrote:
> Here's a small patch replacing the explicit setting of
> XLogCtl->InstallXLogFileSegmentActive with the existing function
> SetInstallXLogFileSegmentActive(), removes duplicate code and saves 4
> LOC.

LGTM

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

  3. Re: Use SetInstallXLogFileSegmentActive() for setting XLogCtl->InstallXLogFileSegmentActive

    Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> — 2022-08-15T06:03:00Z

    On Fri, Aug 12, 2022 at 4:17 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Thu, Aug 11, 2022 at 09:42:18PM +0530, Bharath Rupireddy wrote:
> > Here's a small patch replacing the explicit setting of
> > XLogCtl->InstallXLogFileSegmentActive with the existing function
> > SetInstallXLogFileSegmentActive(), removes duplicate code and saves 4
> > LOC.
>
> LGTM

Thanks for reviewing. I added it to the current commitfest to not lose
track of it - https://commitfest.postgresql.org/39/3815/

--
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/

  4. Re: Use SetInstallXLogFileSegmentActive() for setting XLogCtl->InstallXLogFileSegmentActive

    Michael Paquier <michael@paquier.xyz> — 2022-08-17T06:30:44Z

    On Mon, Aug 15, 2022 at 11:33:00AM +0530, Bharath Rupireddy wrote:
> Thanks for reviewing. I added it to the current commitfest to not lose
> track of it - https://commitfest.postgresql.org/39/3815/

This reduces slightly the footprint of InstallXLogFileSegmentActive,
which is fine by me, so applied.
--
Michael