Re: something has gone wrong, but what is it?

Hi,

On 2022-08-10 10:49:59 -0400, Robert Haas wrote:
> On Wed, Aug 10, 2022 at 9:53 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Robert Haas <robertmhaas@gmail.com> writes:
> >
> > -                       elog(ERROR, "something has gone wrong");
> > +                       elog(ERROR, "unrecognized AuxProcType: %d", (int) auxtype);
> >
> > +1 ... the existing message is clearly not up to project standard.
> 
> After a bit of further looking around I noticed that there's another
> check for an invalid auxtype in this function which uses a slightly
> different message text and also PANIC rather than ERROR.
> 
> I think we should adopt that here too, for consistency, as in the attached.
> 
> The distinction between PANIC and ERROR doesn't really seem to matter
> here. Either way, the server goes into an infinite crash-and-restart
> loop. May as well be consistent.

Makes sense.

Greetings,

Andres Freund