Re: enable/disable broken for statement triggers on partitioned tables
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Simon Riggs <simon.riggs@enterprisedb.com>
Date: 2022-08-01T18:58:08Z
Lists: pgsql-hackers
On 2022-Aug-01, Amit Langote wrote: > On Sat, Jul 30, 2022 at 5:25 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > I do not think it's a great idea to have ALTER TABLE scribbling on > > the source parsetree. > > Hmm, I think we already do scribble on the source parse tree even > before this patch, for example, as ATPrepCmd() does for DROP > CONSTRAINT: > > if (recurse) > cmd->subtype = AT_DropConstraintRecurse; No, actually nothing scribbles on the parsetree, because ATPrepCmd is working on a copy of the node, so there's no harm done to the original. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "I can't go to a restaurant and order food because I keep looking at the fonts on the menu. Five minutes later I realize that it's also talking about food" (Donald Knuth)
Commits
-
Fix ENABLE/DISABLE TRIGGER to handle recursion correctly
- ec0925c22a3d 16.0 landed
- e78fd9084587 15.0 landed
- 731d514ae58f 14.5 landed
- ab855663012c 13.8 landed
- 6e7b37264e96 12.12 landed
- ce8e066521d1 11.17 landed