Horton

Re: Inconvenience of pg_read_binary_file()

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org
Date: 2022-07-30T11:47:05Z
Lists: pgsql-hackers 
On 2022-Jul-30, Michael Paquier wrote:

> PG_VERSION would be simpler.  Looking at postmaster.pid would require
> a lookup at external_pid_file, and as it is not set by default you
> would need to add some extra logic in the tests where
> external_pid_file = NULL <=> PGDATA/postmaster.pid.

Hmm, no? as I recall external_pid_file is an *additional* PID file; it
doesn't supplant postmaster.pid.

postmaster.opts is also an option.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"E pur si muove" (Galileo Galilei)

Commits

  1. Adjust new pg_read_file() test cases for more portability.

  2. Support pg_read_[binary_]file (filename, missing_ok).