Re: enable/disable broken for statement triggers on partitioned tables
Alvaro Herrera <alvherre@alvh.no-ip.org>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <amitlangote09@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Simon Riggs <simon.riggs@enterprisedb.com>
Date: 2022-07-29T18:44:52Z
Lists: pgsql-hackers
Attachments
- triggers-recurse.patch (text/x-diff) patch
On 2022-May-24, Amit Langote wrote: > So, I think we should do something like the attached. A lot of > boilerplate is needed given that the various enable/disable trigger > variants are represented as separate sub-commands (AlterTableCmd > subtypes), which can perhaps be avoided by inventing a > EnableDisableTrigStmt sub-command node that stores (only?) the recurse > flag. Yeah, I don't know about adding tons of values to that enum just so that we can use that to hide a boolean inside. Why not add a boolean to the containing struct? Something like the attached. We can later use the same thing to undo what happens in in AddColumn, DropColumn, etc. It all looks pretty strange and confusing to me. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Investigación es lo que hago cuando no sé lo que estoy haciendo" (Wernher von Braun)
Commits
-
Fix ENABLE/DISABLE TRIGGER to handle recursion correctly
- ec0925c22a3d 16.0 landed
- e78fd9084587 15.0 landed
- 731d514ae58f 14.5 landed
- ab855663012c 13.8 landed
- 6e7b37264e96 12.12 landed
- ce8e066521d1 11.17 landed