Horton

Re: make -C libpq check fails obscurely if tap tests are disabled

Alvaro Herrera <alvherre@alvh.no-ip.org>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Date: 2022-07-22T18:23:23Z
Lists: pgsql-hackers 
On 2022-Jul-21, Andrew Dunstan wrote:

> On 2022-07-21 Th 04:53, Alvaro Herrera wrote:

> > Here's a different take.  Just assign the variable separately.
> 
> Nice, I didn't know you could do that.

It's not very common -- we do have some target-specific variable
assignments, but none of them use 'export'.  I saw somewhere that this
works from Make 3.77 onwards, and we require 3.80, so it should be okay.
The buildfarm will tell us ...

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Industry suffers from the managerial dogma that for the sake of stability
and continuity, the company should be independent of the competence of
individual employees."                                      (E. Dijkstra)

Commits

  1. Increase minimum supported GNU make version to 3.81.

  2. Fix [install]check in interfaces/libpq/Makefile

  3. Run tap tests in src/interfaces/libpq.